This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Merged
Conversation
Member
There was a problem hiding this comment.
Missing a test for failure, i.e. no key present
Member
Author
There was a problem hiding this comment.
Yup, just added it here: fbaiodias@ebf25ef#diff-1a445abf8db16914970d37a823fd6e7eR77
Member
|
Thanks |
LGTM, but I'll let 
Member
|
Thank you Francisco :D great you had the time to finish the PR. I'll be hacking tomorrow the whole afternoon again at the same place, join us :) |
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
There was a test for this but it didn't check the contents of the entire file, only starting from the difference between the offset and the file length. Oops. Fixes ipfs#53
This was referenced Jul 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example uses:
jsipfs config foo- get the foo valuejsipfs config foo bar- set foo as'bar'jsipfs config foo true --bool- set foo astruejsipfs config foo '{"bar: "0"}' --json- set foo as{bar: 0}Related to #49